Skip to content

Pin scikit-build#1098

Closed
tommy-waltmann wants to merge 6 commits intomasterfrom
fix/scikit-build-pin
Closed

Pin scikit-build#1098
tommy-waltmann wants to merge 6 commits intomasterfrom
fix/scikit-build-pin

Conversation

@tommy-waltmann
Copy link
Copy Markdown
Contributor

Description

This PR pins the version of scikit-build in pyproject.toml

Motivation and Context

A recent release of scikit-build may have changed how cmake looks for the python library, which may be the source of some cibuildwheel builds failing in a docker image which provides a statically linked python library. This PR is a test so we can see what happens in the build_wheels environment.

How Has This Been Tested?

Screenshots

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@tommy-waltmann
Copy link
Copy Markdown
Contributor Author

I am going to pin scikit-build to 0.17.1 here so we can release freud version 2.13.0 in the near future, and we'll be on the lookout for a new scikit-build release which has the fix from scikit-build/scikit-build#958

@tommy-waltmann tommy-waltmann marked this pull request as ready for review April 27, 2023 17:00
@tommy-waltmann tommy-waltmann requested review from a team and vyasr and removed request for a team April 27, 2023 17:00
@tommy-waltmann tommy-waltmann mentioned this pull request Apr 27, 2023
11 tasks
@tommy-waltmann
Copy link
Copy Markdown
Contributor Author

superseded by #1099

@tommy-waltmann tommy-waltmann deleted the fix/scikit-build-pin branch October 5, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant