Pin scikit-build#1098
Closed
tommy-waltmann wants to merge 6 commits intomasterfrom
Closed
Conversation
Contributor
Author
|
I am going to pin scikit-build to 0.17.1 here so we can release freud version 2.13.0 in the near future, and we'll be on the lookout for a new scikit-build release which has the fix from scikit-build/scikit-build#958 |
Contributor
Author
|
superseded by #1099 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR pins the version of scikit-build in
pyproject.tomlMotivation and Context
A recent release of scikit-build may have changed how cmake looks for the python library, which may be the source of some cibuildwheel builds failing in a docker image which provides a statically linked python library. This PR is a test so we can see what happens in the build_wheels environment.
How Has This Been Tested?
Screenshots
Types of changes
Checklist: