Merged
Conversation
lukasmasuch
commented
Jan 9, 2024
| readonly target: Rectangle; | ||
| readonly forceEditMode: boolean; | ||
| readonly isValid?: boolean; | ||
| readonly theme: Theme; |
Collaborator
Author
There was a problem hiding this comment.
I added this to make the theme available to custom editors, but eventually ended up not using this. But I think it could be useful to have access to this when implementing editors. Wdyt?
lukasmasuch
commented
Jan 9, 2024
|
|
||
| drilldownCache[key] = canvas; | ||
|
|
||
| const trueRounding = Math.min(rounding, targetWidth / 2, targetHeight / 2); |
Collaborator
Author
There was a problem hiding this comment.
I removed this because the overlay editor also just used a static value (6px), but I can also try to figure out how to keep this logic in. Wdyt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces an optional
roundingRadiustheming option which is used as a default/fallback for rounded rects in GDG:This is applied in:
Example with
roundingRadius==6Closes #845