fix nested Type names in BAML -> XAML decompile#3
Merged
glenn-slayden merged 2 commits intomasterfrom Apr 25, 2023
Merged
Conversation
use '+' when decompiling from BAML to XAML when some MarkupExtensions contain nested Type names e.g.
System.Activities.Presentation.View.VBIdentifierDesigner ...
--> "{x:Static sad:WorkflowDesignerIcons+DesignerItems.WarningValidation}"
Nested Type names were quite broken. Of course they are doomed in XAML anyway, but this solves a fair about of the corruption and crashing-out-of-decompile problems. Examples now much improved: System.Activities.Presentation.View.TypeBrowser System.Activities.Core.Presentation.FlowchartDesigner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested Type names were quite broken. Of course they are doomed in XAML anyway, but this solves a fair about of the corruption and crashing-out-of-decompile problems.
Examples now much improved:
System.Activities.Presentation.View.TypeBrowser
System.Activities.Core.Presentation.FlowchartDesigner
System.Activities.Presentation.View.VBIdentifierDesigner