fix loop guards + let + destructuring issues #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@vendethiel, review? |
Contributor
|
Seems to work in the cases I tested. I still would like if you added tests like: nested ( |
rhendric
force-pushed
the
fix/LiveScript-992
branch
2 times, most recently
from
4b6a5f5 to
f9877c2
Compare
Hat tip to vendethiel for reporting and writing tests.
rhendric
force-pushed
the
fix/LiveScript-992
branch
from
f9877c2 to
a9ae089
Compare
Collaborator
Author
|
Is this better? Any more cases you think are relevant? |
Contributor
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #994, closes #992.