Fix inline from0 #229
Merged
Fix inline from0 #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi I'm currently travelling and just have my iPhone. I'll take a look at this and the other stuff when I get back home |
Contributor
Author
|
Sure, no hurry :) Might be really easier by checking before, maybe ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #217
sorry for the PR spam, I'm just trying to hack into the compiler.
It's really hard to understand how things work if you never got into it.
This fix seems to be a bit of a mess to me, but that's the only way I found to dry it. All tests pass so, yeah. I'd also be glad to be told how it's supposed to be done :)
It appears I'm unable to rebase because for some reason, git fails to load vi/vim blah blah ... Not sure what's happening here, if it really matters, tell me.