Fix #1035 #1036
Merged
Fix #1035 #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes build-parser print error messages about shift/reduce and reduce/reduce conflicts to stderr instead of prepending them to lib/parser.js. It also halts the build and leaves lib/parser.js untouched if there are any such messages. It's a bit of a hack, but it greatly improves the ergonomics of tinkering with the grammar.
Contributor
|
Oops I didn't knew LSC had a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a quick grammar tweak; honestly I'm shocked that this hasn't been caught and fixed earlier. But here we are.
Fixes #1035. Will merge on or after April 5.