Repository navigation
BVHHelper: Skip nodes with empty bounds - #949
Merged
gkjohnson merged 1 commit intoNov 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #892
A BVH built from an empty geometry has a root node with empty bounds (min = Infinity, max = -Infinity).
BVHHelperstill emitted a box for it, so the helper geometry ended up with infinite vertex positions, and three.js logged "Computed radius is NaN" when it computed the bounding sphere for frustum culling.The helper now skips nodes with empty bounds, both when counting the boxes and when writing their positions, so an empty BVH produces an empty helper geometry. I added a test for the empty case and a basic sanity test for a regular mesh. There were no
BVHHelpertests yet.I wasn't sure whether this covers everything you had in mind for #892, so I referenced the issue instead of closing it.