Repository navigation
fix(blend): composite colors using their alpha values - #407
Merged
Merged
Conversation
|
gka
added a commit
that referenced
this pull request
Oct 24, 2026
Co-authored-by: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #281.
blend()reads both inputs withrgb(), discarding their alpha values. A transparent top color can therefore change the bottom color, and two transparent inputs can produce an opaque result.Composite the existing RGB blend functions using source-over alpha, with the second color over the first. Handle transparent operands before evaluating the blend, and clamp the overlap color before weighting it. Also handle the white-backdrop/black-source
burnendpoint, which currently throws on0/0.The existing opaque RGB results and clipping behavior are retained, except that the undefined
burnendpoint now returns white. Translucent results can now include alpha in the defaulthex()output; the documentation includes examples. A NaN alpha set through the mutating setter is now rejected.Validation:
pnpm lint,pnpm test -- --run(2,582 tests), andpnpm buildpass.pnpm run docspasses on Node 24.18.1/Linux.Regression coverage includes all eight modes, transparent and partially transparent operands, direct mode methods, RGB rounding, input Color immutability, burn clipping, and alpha modified through the mutating setter. No dependencies or generated files change.