Skip to content

First "new" design approach - #96

Closed
mangerlahn wants to merge 7 commits into
gitx:masterfrom
mangerlahn:feature-toolbar
Closed

mangerlahn wants to merge 7 commits into
gitx:masterfrom
mangerlahn:feature-toolbar

Conversation

@mangerlahn

Copy link
Copy Markdown
Contributor

This pull request gets rid of the MGScopeBar, the in-document toolbar and the bottom bar. It moves all those buttons into a new toolBar which is placed inside the windows frame under the title.

This design was discussed in #91 and is expected to improve.

This first commit has no working search and the performance is very poor.

@ksuther

ksuther commented May 22, 2017

Copy link
Copy Markdown
Contributor

You may want to consider working off of #88, assuming it ever gets merged. It made changes to all the nibs to use Auto Layout, removed old code, and fixed split view and window frame restoration (all of which will cause conflicts for you).

mangerlahn and others added 6 commits May 23, 2017 07:25
…as causing it to scroll horizontally before it would start wrapping.
Staging table views and text view aren't in NSBoxes anymore, it's cleaner to use a view and a separate label.
Removed PBNiceSplitView and using the system split view instead.
If frame isn't explicitly set using the autosaveName then the autosaveName is only used for the first two windows. Opening the third and subsequent windows then start using the default window size instead of the autosave frame.
@mangerlahn

Copy link
Copy Markdown
Contributor Author

Oops, i forgot about that. Thanks!

@mangerlahn

Copy link
Copy Markdown
Contributor Author

Before I continue optimising the design approach I wanted to ask you what you think, what we should change and what can stay that way (and get polished!)

@jspiro

jspiro commented Jan 26, 2021

Copy link
Copy Markdown
Member

Can we revive this?!

@hannesa2

Copy link
Copy Markdown
Contributor

It would be nice, when you rebase to recent master to have a CI build. Thank you !

@hannesa2 hannesa2 added the need rebase The branch needs a rebase to be able to merge label Feb 3, 2021
@jspiro jspiro closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need rebase The branch needs a rebase to be able to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants