Repository navigation
Change Amend Commit menu item to use an action instead of bindings - #95
Merged
Merged
Conversation
Bindings can make the menu item behavior act erratically because the binding state is shared across the app, not per-document. This also adds a checkmark to the menu item when amending is active. Steps to reproduce a problem like this: - Open a repository - Select Amend Commit to start amending - Close the repository - Open the same repository - Select Amend Commit to start amending again - This time the menu item sets amend to NO instead of YES, so nothing happens the first time you select the menu item
Contributor
Author
|
Any possibility of merging these and other recent PRs? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bindings can make the menu item behavior act erratically because the binding state is shared across the app, not per-document.
This also adds a checkmark to the menu item when amending is active.
Steps to reproduce a problem like this: