Repository navigation
Split view modernization, better window frame restoration and other fixes - #88
Merged
Merged
Conversation
Contributor
Author
|
Added better window frame saving as well. It would have caused merge conflicts to put them in a separate branch. |
ksuther
changed the title
Contributor
|
I gave that a spin, and Xcode logged that : Care to fix it ? |
Contributor
Author
|
That looks like it's coming from QuickLook, not our window or views. I'll see if I can get it to happen to make sure. |
Split view positions aren't preserved yet.
…as causing it to scroll horizontally before it would start wrapping.
Staging table views and text view aren't in NSBoxes anymore, it's cleaner to use a view and a separate label. Removed PBNiceSplitView and using the system split view instead.
If frame isn't explicitly set using the autosaveName then the autosaveName is only used for the first two windows. Opening the third and subsequent windows then start using the default window size instead of the autosave frame.
… hasn't been loaded.
Contributor
Author
|
Fixed the |
Contributor
Author
|
Any chance of getting this and other PRs merged or commented on? |
Contributor
|
Looks good, thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted nibs with split views to Auto Layout and using split view autosave instead of managing it all by hand.
Auto Layout also gives us much cleaner resizing of split views.
One thing that was lost was the collapsable split view in the history view, but it can be reimplemented using the newer NSSplitView delegate methods much more easily in the future.