Repository navigation
Fix gitx --version reporting a stale version - #771
Merged
Merged
Conversation
Read the version from the app bundle that contains the tool, so `gitx --version` matches the version shown by the app. - Report CFBundleVersion of the enclosing GitX.app - Fall back to the tool's own plist outside an app bundle - Share the app lookup with the scripting bridge
goneng
force-pushed
the
report-the-real-version-from-the-gitx-tool
branch
from
October 23, 2026 18:13
698c973 to
eb6221e
Compare
goneng
marked this pull request as ready for review
October 24, 2026 07:48
hannesa2
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the version from the app bundle that contains the tool, so
gitx --versionmatches the version shown by the app.Details
gitx --versionprintedGitX version 0.12, whatever the release.The tool reads the plist embedded in its own binary, which uses the
stale
CURRENT_PROJECT_VERSIONbuild setting.scripts/set-git-version-info.shonly writes the git-derived version into the app'sInfo.plist.CFBundleVersionof the enclosing GitX.app, the build number the app reports (e.g.1.7.1.3511 [arm])gitXApplication)Screenshots
Before - Fixed at Stale Version '0.12'
After - Matches the Version of GitX Executable
Test plan
GitX.app/Contents/Resources/gitx --versionprints the app's version, not 0.12/usr/local/bin/gitxis installed): same outputmake smoke-teststill finds "GitX version"