Repository navigation
Conversation
- testRepositoryFolderOpensThroughLaunchServices: close the repository window via its close button instead of Cmd-W, which was not reliably closing the window on every machine. The expectation now asserts the wait actually completed, and a comment clarifies that any window seen after the Launch Services open event must be newly created, since the original was confirmed fully closed beforehand. - Run `make format` to apply clang-format to the lines added in PBGitXDocumentTypesTests.m and GitXScreenshotTests.m (array literal spacing, wrapped URLByAppendingPathComponent: calls, argument alignment, and brace placement on the new test method).
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test reliability fix is correct, bounded, and consistently formatted.
0 open findings
What changed in this PR
Improves reliability and formatting of Launch Services tests.
Changes:
- Closes the repository window through its close button and verifies completion.
- Applies clang-format to modified Objective-C tests.
| File | Description |
|---|---|
GitXUITests/GitXScreenshotTests.m |
Makes repository reopening test more reliable. |
GitXTests/PBGitXDocumentTypesTests.m |
Formats Launch Services test code. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Screenshot differs: emulatorApi=arm64 with 1 screenshot(s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make formatto apply clang-format to the lines added in PBGitXDocumentTypesTests.m and GitXScreenshotTests.m (array literal spacing, wrapped URLByAppendingPathComponent: calls, argument alignment, and brace placement on the new test method).