Repository navigation
Fix Open in Terminal running commands found in the repository path - #759
Merged
Merged
Conversation
Pass the repository path to the shell as literal text, so a folder name holding shell syntax is entered rather than evaluated. - Single-quote the directory in the line sent to Terminal and iTerm2, escaping embedded single quotes; double quotes still expanded $(...) and backticks - Test that the line quotes such a path, and that /bin/sh running it ends up in a directory named with $(...), backticks and quotes Ported from hbmartin/gitx@7305c7db (the quoting only).
hannesa2
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the repository path to the shell as literal text when opening it in
Terminal or iTerm2, so a folder name holding shell syntax is entered
rather than evaluated.
escaping embedded single quotes; double quotes still expanded
$(...)and backticks
Test plan:
PBTerminalHandlerPreferenceTestschecks the quoted line, and runs itthrough
/bin/shin a directory named with$(...), backticks andquotes; it fails before the change and passes after
iTerm2: on an ordinary repository it opens there and runs
git status; on one whose folder name contains$(...), backticksand a quote, the shell enters that folder as named and nothing in the
name is executed