Repository navigation
Remove zip from uploaded artifacts - #757
Merged
Merged
Conversation
hannesa2
marked this pull request as draft
October 4, 2026 05:59
hannesa2
marked this pull request as ready for review
October 4, 2026 06:21
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The artifact flow is consistent, with only minor stale Makefile documentation remaining.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Removes broken ZIP distribution artifacts, leaving DMGs as the sole downloadable release format.
Changes:
- Stops generating and uploading distribution ZIPs.
- Removes ZIPs from release downloads and assets.
| File | Description |
|---|---|
Makefile |
Removes ZIP packaging. |
.github/workflows/BuildPR.yml |
Removes ZIP artifact and release handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hannesa2
force-pushed
the
RemoveZipFromArtifacts
branch
from
October 4, 2026 06:27
06bfa92 to
9ba0c59
Compare
hannesa2
force-pushed
the
RemoveZipFromArtifacts
branch
from
October 4, 2026 06:57
9ba0c59 to
5c2da37
Compare
Co-authored-by: hannesa2 <[email protected]>
Contributor
Author
|
@goneng Do you see any reason to keep the (broken) zip artifact and rather repair the zip ? |
Contributor
Author
goneng
approved these changes
Oct 5, 2026
goneng
left a comment
goneng
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - we really don't need the zip anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's broken #380 (comment)