Repository navigation
Fix the dialog warnings test failing on master - #755
Merged
Merged
Conversation
List the force push with lease dialog in the Preferences warnings, so the test that every suppressible dialog is registered passes again. - Add a kDialogForcePushWithLease constant and use it at the call site. - Register the dialog with a title and description in dialogWarnings. - The two pull requests that introduced the dialog and the test were each green alone, and failed once both were merged.
goneng
marked this pull request as ready for review
October 3, 2026 15:14
Collaborator
Author
Collaborator
Author
|
@hannesa2 - CI is fixed - please merge |
Collaborator
Author
|
@hannesa2 - I'm taking the liberty to merge this fix to stabilize the CI |
Contributor
When you think it's fine: do it ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI-tests - the failing dialog warnings test on
master-by registering the force push with lease dialog in the Preferences' Warnings list.
PBGitWindowController instead of the string literal.
description.
Test plan:
testEverySuppressibleDialogIsRegistered, which fails on master.
Preferences; not checked by eye.