Skip to content

Capture the Warnings tab in the Settings screenshots - #754

Merged
hannesa2 merged 1 commit into
masterfrom
warnings-screenshot
Oct 3, 2026
Merged

hannesa2 merged 1 commit into
masterfrom
warnings-screenshot

Conversation

@goneng

@goneng goneng commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

Show the Warnings tab added in #750 in the PR screenshot comparison, as the General and Integration tabs already are.

  • Add testSettingsWarningsTabScreenshot, which opens the Warnings tab and saves it as settings-warnings.

Test plan:

  • testSettingsWarningsTabScreenshot passes locally and attaches settings-warnings.
  • The first comparison on this PR has no baseline for settings-warnings; expect it to report the new image only.

@goneng
goneng marked this pull request as ready for review October 3, 2026 15:07
@goneng goneng added the test Test related label Oct 3, 2026
Show the Warnings tab in the screenshot comparison, as the General and
Integration tabs already are.

- Add a UI test that opens the Warnings tab and saves it as
  settings-warnings.
@goneng
goneng force-pushed the warnings-screenshot branch from 8eaf178 to 9fbecde Compare October 3, 2026 16:28
@hannesa2

hannesa2 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Screenshot differs: emulatorApi=arm64 with 1 screenshot(s)

setpoint (old) | diff | actual screenshot (new)

scripts/Screenshots-arm64/settings-warnings.png (new screenshot)
screenshot

@goneng

goneng commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

@hannesa2 , this is a new tab that was added - but was not listed as part of the tests

@hannesa2
hannesa2 merged commit b8934ce into master Oct 3, 2026
3 checks passed
@hannesa2
hannesa2 deleted the warnings-screenshot branch October 3, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants