Repository navigation
Fix the false "Multiple commits are selected" message - #753
Merged
Merged
Conversation
goneng
marked this pull request as ready for review
October 3, 2026 14:34
goneng
force-pushed
the
fix-stuck-multiple-commits-message
branch
from
October 3, 2026 14:51
3f8609a to
c1b7e7a
Compare
Reset the remembered commit when the multiple-selection message is shown, so selecting the commit shown before it loads the details again. - Clear currentOID in changeContentToMultipleSelectionMessage. - Without it, selecting the previously shown commit only reloaded its ref labels and left the message on screen.
Clear the revision list as soon as a new load starts, so a second update arriving before the first chunk cannot re-graph the previous load. - Replace the lazy resetCommits flag in PBGitRevList with an immediate reset in loadRevisionsWithCompletionBlock. - Without it, the old commits were graphed again and the new load was appended after them, so selecting a commit selected both copies and showed "Multiple commits are selected".
Start the rev list tests from the cleared array a load now creates, and cover that a new load clears the previous commits at once. - Drop the removed resetCommits property from the test category. - Add a test that starting a load empties the earlier commits.
goneng
force-pushed
the
fix-stuck-multiple-commits-message
branch
from
October 3, 2026 16:31
c1b7e7a to
303e7f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop the history view showing "Multiple commits are selected" while a
single commit is highlighted.
A second history update arriving before the first chunk of the new
load re-graphed the old list and then had the new load appended to it,
so every commit was in the list twice. Picking a commit by ID then
selected both copies.
shown, so selecting the previously shown commit loads its details
again instead of leaving the message on screen.
Test plan:
clone of GitX took the list from 3764 to 7528 commits. With the fix
it stays at 3764.
is GitX's own double update, which I could not produce from outside
the app.