Repository navigation
[UI] Fix the Source / Blame / History bar being unreadable in dark mode - #751
Merged
Merged
Conversation
Pick up the MGScopeBar fix that draws the bar above the file view in dark colours under a dark appearance (gitx/MGScopeBar#26). - Bump External/MGScopeBar to 2671a7e, which contains only that fix - Light mode is unchanged: the bar renders byte-identical to before
Collaborator
Author
|
(tested OK - in Dark and Light modes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick up the MGScopeBar fix that draws the bar above the file view (Tree
view: Source / Blame / History) in dark colours under a dark
appearance. Before, it always painted a light-grey gradient while its
buttons' titles turned light, so they were barely readable.
Changes
External/MGScopeBarto2671a7e, which contains only thatfix ([UI] Fix scope bar text unreadable in dark mode MGScopeBar#26)
Screenshots
Before (Dark Mode)
After (Dark Mode)
After (Light Mode)
Test plan
dark under Dark Aqua
file, and check Source / Blame / History are readable and the
selected one stands out