Repository navigation
List the suppressible confirmation dialogs in Preferences - #750
Merged
Merged
Conversation
goneng
force-pushed
the
dialog-warnings-list
branch
6 times, most recently
from
October 3, 2026 11:06
0e0ac74 to
c2821c4
Compare
goneng
marked this pull request as ready for review
October 3, 2026 12:19
goneng
force-pushed
the
dialog-warnings-list
branch
from
October 3, 2026 12:39
c2821c4 to
19f40ec
Compare
Show each confirmation dialog GitX can stop asking about, with whether it is currently ignored, and let the user toggle it individually. - Register every suppressible dialog in PBGitDefaults with a title and a one-line description, and use shared constants at the call sites. - Add a Warnings tab with an introductory sentence, the list, a separator and the Reset Warnings button. - Size the list to the registered dialogs, scrolling past eight rows. - Ignore a remembered Preferences tab this build does not have, so a downgrade still opens the window. - Give the Preferences window a minimum width so all four tabs fit. - Make a checked row mean the same as the box in the dialog itself: the dialog is not shown. - Keep the storage as is: the table reads and writes the existing "Suppressed Dialog Warnings" set, so it and Reset Warnings cannot disagree. - Run the tests against a settings store of their own, so they do not touch the user's saved warnings or remembered tab. - Fail the tests when a confirmation dialog is added without a registry entry.
goneng
force-pushed
the
dialog-warnings-list
branch
from
October 3, 2026 12:42
19f40ec to
2a571da
Compare
Contributor
|
Screenshot differs: emulatorApi=arm64 with 4 screenshot(s) |
Collaborator
Author
|
@hannesa2 , I think we have a lot of new content and bug-fixes since v1.6 - maybe it is time for a new release |
Contributor
|
Is the worktree ready to ship? |
Collaborator
Author
Yes - there is one small enhancement that can wait for the next release - |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show each confirmation dialog GitX can stop asking about in a new Warnings Preferences tab, with whether it is currently ignored, and let the user toggle it.
Workplan
Screenshots
Test plan