Repository navigation
Fix a spurious invalid git path alert at login - #748
Merged
Merged
Conversation
Validate the configured git path in the background so a transient failure of the `/usr/bin/git` shim at login no longer blocks launch or raises a false alert. - Trust an executable configured path at once and run `--version` off the main thread - On failed validation, log it, fall back to the default search and show the alert - Log launch errors and unparseable `--version` output instead of dropping them - Move the default search and the alert into their own methods Fixes #744
goneng
force-pushed
the
fix/git-path-startup-validation
branch
from
October 3, 2026 00:40
b2314ef to
43f6ab3
Compare
goneng
marked this pull request as ready for review
October 3, 2026 05:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate the configured git path in the background, so a transient failure of the
/usr/bin/gitshim at login no longer blocks launch or raises a false "Invalid git path" alert.--versionoff the main thread--versionoutput instead of dropping them+[PBGitBinary version]is nil until validation finishes; callers already handle nil (worktree actions show "Requires git X or later" briefly).The root cause is unconfirmed: the likely culprit is the Command Line Tools shim failing early in login. The new logging should show it if it recurs.
Fixes #744
Test plan:
-gitExecutable /usr/bin/git): no alert, repo opens/usr/bin/true): logged, falls back to default search, alert shown