Skip to content

Use Homebrew's autobump for the cask-bump - #747

Merged
hannesa2 merged 1 commit into
masterfrom
release-leave-homebrew-to-autobump
Oct 6, 2026
Merged

Use Homebrew's autobump for the cask-bump#747
hannesa2 merged 1 commit into
masterfrom
release-leave-homebrew-to-autobump

Conversation

@goneng

@goneng goneng commented Oct 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Stop maintaining a cask update that Homebrew already does on its own.
The gitx cask is on Homebrew's autobump list (autobump=true), so
BrewTestBot opens the version bump PR for each new GitHub release by itself,
and brew bump-cask-pr refuses manual bumps for it.

For 1.7 the two raced: BrewTestBot's Homebrew/homebrew-cask#291707 and
the release job's Homebrew/homebrew-cask#291706 opened in the same minute,
and Homebrew merged the bot's.
On being told when something goes wrong, a Homebrew maintainer answered in #291707
that they handle all bumps and failures, and notify upstream by
mentioning us in the PR or opening an issue here.

Changes

  • Remove the release job's Homebrew steps:
    checking out homebrew-cask, updating Casks/g/gitx.rb, fetching the PR template,
    and opening the PR from hannesa2/homebrew-cask.
  • Remove scripts/update-homebrew-cask.sh (from Keep the Homebrew cask intact when its layout changes #752), which only those steps used.
  • Keep publishing the release and the Sparkle feed as they are.

The release job no longer uses PERSONALACCESSTOKEN, which nothing else in the workflows reads.

Test plan

  • brew info --cask homebrew/cask/gitx reports autobump=true, and brew livecheck skips it with "autobumped in homebrew/cask".
  • The workflow still parses, with the release job ending at "update Sparkle"; CI on this PR confirms it.
  • 1.7 was already bumped by BrewTestBot alone (#291707); after the next release, it should be the only bump PR.

@goneng
goneng requested a review from hannesa2 October 2, 2026 23:07
@goneng
goneng marked this pull request as ready for review October 2, 2026 23:07
@goneng
goneng force-pushed the release-leave-homebrew-to-autobump branch from 91511df to c9243b2 Compare October 2, 2026 23:16
@hannesa2 hannesa2 added the pipeline CI pipeline label Oct 3, 2026
@hannesa2

hannesa2 commented Oct 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The result is somehow magic and no more understandable, where the new version appears suddenly by itself in brew.
If it break, you'll never know why, or where to investigate. Even I (at least) loose the blueprint how to brew publish for other repositories.

But we can give it a try...

hannesa2
hannesa2 previously approved these changes Oct 3, 2026
View reviewed changes

@hannesa2 hannesa2 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it with reservation.

The disadvantage of this, that you don't know immediate if it's working or not. I at least avoid to have too much things in my head which I should check in hours, days, week.... It's better to do everything now

@goneng

goneng commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

I approve it with reservation.

The disadvantage of this, that you don't know immediate if it's working or not. I at least avoid to have too much things in my head which I should check in hours, days, week.... It's better to do everything now

I see your point, but at the current state, if Homebrew change their template-format - our Homebrew releases may fail, and it may not be trivial to debug.

@hannesa2

hannesa2 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

if Homebrew change their template-format - our Homebrew releases may fail, and it may not be trivial to debug.

Right, this was the case in the past Homebrew/homebrew-cask#280021 (luckily I received an email) and I solved it with #574

Do I receive emails in the future on issues concerning publish to https://github.com/Homebrew/homebrew-cask ?

@goneng
goneng marked this pull request as draft October 3, 2026 09:40
@goneng

goneng commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

Good question 🙂
I've set this PR as "Draft" for now, until I have a better answer...

@hannesa2

hannesa2 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

if Homebrew change their template-format - our Homebrew releases may fail, and it may not be trivial to debug.

Right, this was the case in the past Homebrew/homebrew-cask#280021 (luckily I received an email) and I solved it with #574

Do I receive emails in the future on issues concerning publish to https://github.com/Homebrew/homebrew-cask ?

In the past it was not the same precondition, as a pull request already exists. At least that time, there was no no self-healing-automated solution after 3 hours (additional with a notification).
This would be my expectation, when it would be complete decoupled-to-existing-pull-request automatic publish after 3 hours

@hannesa2

hannesa2 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

How to test a failure to an automated publish to brew ?

@goneng goneng mentioned this pull request Oct 3, 2026
Merged
@goneng

goneng commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator Author

How to test a failure to an automated publish to brew ?

I'm not sure how you/we get notified about such issues, so closing this one for now.

@goneng goneng closed this Oct 3, 2026
@hannesa2

hannesa2 commented Oct 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm not sure how you/we get notified about such issues

@goneng
This is the answer Homebrew/homebrew-cask#291707 (comment)
I'm fine to merge this

@goneng goneng reopened this Oct 5, 2026
@goneng
[Homebrew] Leave the Homebrew cask bump to Homebrew's autobump
586153b 
Stop maintaining a cask update that Homebrew already does on its own:
the gitx cask is autobumped, so BrewTestBot opens the version bump PR
for each release, and Homebrew reports any problem with it to us.

- Remove the release job's steps that update Casks/g/gitx.rb and open
  the bump PR from a fork, which for 1.7 only duplicated the bot's
- Remove scripts/update-homebrew-cask.sh, which only those steps used
- Keep publishing the release and the Sparkle feed as they are
@goneng
goneng force-pushed the release-leave-homebrew-to-autobump branch from c9243b2 to 586153b Compare October 5, 2026 21:55
@goneng goneng changed the title Leave the Homebrew cask bump to Homebrew's autobump Use Homebrew's autobump for the cask-bump Oct 5, 2026
@goneng
goneng marked this pull request as ready for review October 5, 2026 22:38
@hannesa2
hannesa2 merged commit 8e3312b into master Oct 6, 2026
3 checks passed
@hannesa2
hannesa2 deleted the release-leave-homebrew-to-autobump branch October 6, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannesa2 hannesa2 hannesa2 left review comments

Assignees

No one assigned

Labels

pipeline CI pipeline

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goneng @hannesa2