Repository navigation
Apply fuzz before the early identical-image check in screenshot compare - #743
Merged
Merged
Conversation
Contributor
Author
Fixes the remaining noisy-screenshot-diff problem: the early exact pre-check in diff-image ran without -fuzz and was gated on an exif diff that almost always fires because 'File Size' changes with any byte difference. Together these meant a noisy (but visually identical once fuzzed) screenshot pair still produced a diff file, even though the rendered montage showed nothing highlighted. refs: hannesa2/git-diff-image#3
hannesa2
force-pushed
the
fix/noisy-screenshot-prefuzz
branch
from
October 1, 2026 05:37
f2e0387 to
675dfbb
Compare
Contributor
Author
|
Unfortunately #736 comes still with screenshot compare issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining noisy-screenshot-diff problem: the early exact pre-check in diff-image ran without
-fuzzand was gated on an exif diff that almost always fires because 'File Size' changes with any byte difference. Together these meant a noisy (but visually identical once fuzzed) screenshot pair still produced a diff file, even though the rendered montage showed nothing highlighted.refs: hannesa2/git-diff-image#3