Repository navigation
[UI] Fix the selected history view being hard to tell apart in dark mode - #742
Merged
Merged
Conversation
Draw the Detailed / Tree view switch in the standard rounded style, whose selected segment stands out in both appearances. - Change the switch's segment style from textured square to rounded - Leave the action buttons next to it as they are; disabled ones already dim their icons
Contributor
|
Screenshot differs: emulatorApi=arm64 with 2 screenshot(s) |
goneng
changed the title
goneng
marked this pull request as ready for review
September 30, 2026 22:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draw the Detailed / Tree view switch above the history list in the
standard rounded style, whose selected segment stands out in both
appearances. With the textured square style, the selected segment in
dark mode was only a shade lighter than the other one.
Changes
already dim their icons
Screenshots
Before
After
Test plan
ibtoolon the xib: no new warnings or notices compared with master,and it compiles
dark: rounded is the one whose selected segment is clear in both
or Tree, is clearly lighter than the other one