Repository navigation
Fix Settings screenshots reporting changes behind the panel - #726
Merged
Merged
Conversation
Keep what shows through the Preferences panel's rounded corners out of its screenshot, so a PR that changes the main window stops being reported as a Settings change. - Paint everything outside an inset rounded rect white before saving the Settings captures; the inset and radius cover the Tahoe corner, which runs further along each edge than a plain circle - Attach the masked image as PNG data, which the extractor accepts - Link AppKit into GitXUITests for the bitmap drawing
Contributor
|
Screenshot differs: emulatorApi=arm64 with 2 screenshot(s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep what shows through the Preferences panel's rounded corners out of
its screenshot, so a PR that changes the main window stops being
reported as a Settings change.
Details
Example: #723 changes only the sidebar, yet its comparison flagged
settings-general.png(#723 (comment)). All
223 differing pixels are in the panel's corners, where the main window
shows through.
the Settings captures; the inset and radius cover the Tahoe corner,
which runs further along each edge than a plain circle
Screenshot from #723
Test plan
pixels, dialog content unchanged
white corners only, since the master baseline is unmasked