Repository navigation
ObjectiveC bump Xcconfig 1.1 - #718
Merged
Merged
Conversation
hannesa2
force-pushed
the
ObjectiveC-bump-BumpXcconfig-1.1
branch
from
September 22, 2026 09:00
df9bada to
89b2bfc
Compare
Co-authored-by: hannesa2 <[email protected]>
The previous fix set CODESIGN_DIGEST_ALGORITHM=sha256, which isn't a real Xcode build setting, so it had no effect and codesign kept defaulting to a SHA1-only digest for ad-hoc, non-hardened-runtime test builds. Newer codesign (Xcode 26.3+, matching CI) hard-rejects that with "signing with only SHA1 not allowed". OTHER_CODE_SIGN_FLAGS is what actually reaches codesign's invocation. Setting it on the command line replaces (rather than merges with) the xcconfig's own OTHER_CODE_SIGN_FLAGS = --timestamp=none, so both flags are repeated here to keep timestamping disabled and switch codesign to sha256. Reproduced locally: xcodebuild passed --digest-algorithm=sha1 and failed with the exact CI error; overriding OTHER_CODE_SIGN_FLAGS to include --digest-algorithm=sha256 fixed it, and `make unit-test` now passes all 202 GitXTests.
hannesa2
force-pushed
the
ObjectiveC-bump-BumpXcconfig-1.1
branch
from
September 23, 2026 04:15
89b2bfc to
bdd0190
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs gitx/objective-git#48