Repository navigation
Support choosing light, dark, or the system appearance (issue #714) - #715
Merged
Merged
Conversation
goneng
force-pushed
the
choose-light-dark-or-system-appearance
branch
2 times, most recently
from
September 22, 2026 18:26
482ccdc to
2489441
Compare
Some users want GitX to stay light or dark whatever the rest of the Mac is doing, which until now only System Settings could decide. - Store the choice as PBAppearance, defaulting to following the system - Apply it to NSApp.appearance before the first window opens, so no window shows the wrong appearance at launch - Offer it as a popup in Settings > General and as a View > Appearance submenu, both driving the same default - Leave every existing consumer of the appearance alone: overriding NSApp.appearance updates effectiveAppearance, which already drives them - Give the General pane the height the new row needs, and settle the Integration pane on the same margins while there, so all three panes stand 38 points clear at the top and 35 at the bottom
goneng
force-pushed
the
choose-light-dark-or-system-appearance
branch
from
September 22, 2026 20:08
2489441 to
02c4fee
Compare
goneng
marked this pull request as ready for review
September 22, 2026 20:31
hannesa2
approved these changes
Sep 23, 2026
hannesa2
left a comment
hannesa2
left a comment
Contributor
There was a problem hiding this comment.
Nice, I'm fine with it. But wait for the Copilot review, if it finds a high issue
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Invalid persisted appearance values can leave the Settings popup and menu checkmark unsynchronized.
Review effort: Lite
Findings: None
What changed in this PR
Adds persistent System, Light, or Dark appearance selection, applied at launch and exposed in Settings and the View menu.
Changes:
- Stores and retrieves the appearance preference.
- Applies appearance changes globally.
- Adds synchronized Settings and View menu controls.
| File | Description |
|---|---|
Resources/en.lproj/Preferences.xib |
Adds the appearance preference popup. |
Resources/en.lproj/MainMenu.xib |
Adds the Appearance submenu. |
Classes/git/PBGitDefaults.m |
Stores and retrieves the appearance setting. |
Classes/git/PBGitDefaults.h |
Defines the appearance settings API. |
Classes/Controllers/ApplicationController.m |
Applies and validates appearance choices. |
Classes/Controllers/ApplicationController.h |
Declares the appearance action. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users want GitX to stay light or dark whatever the rest of the Mac is doing, which until now only System Settings could decide. Closes #714.
PBAppearance, defaulting to following the systemNSApp.appearancebefore the first window opens, so no window shows the wrong appearance at launchNSApp.appearanceupdateseffectiveAppearance, which already drives themnilis what "System" applies, rather than reading the system setting and applying it explicitly, so following the system stays live.Screenshots
Test plan
PBAppearanceset to Dark on a Light Mac: the app comes up dark, with no flash of the wrong appearance