Repository navigation
Bump objective-git to stop building the libgit2 test suite - #708
Merged
hannesa2 merged 1 commit intoSep 21, 2026
Merged
Conversation
Contributor
|
I merged gitx/objective-git#108 and gitx/objective-git#107 |
Every GitX build runs libgit2's cmake build, which compiled a Clar test suite that is never run, because the flag meant to switch it off stopped matching libgit2's own option name at the 1.x rename. - Move the objective-git pointer onto gitx/objective-git#108, which passes -DBUILD_TESTS:BOOL=OFF in place of the dead -DBUILD_CLAR:BOOL=OFF and cuts 471 of the 667 objects the build compiles. - Take that fix alone rather than the current objective-git master, which has since moved on to unrelated work in gitx#107.
goneng
force-pushed
the
bump-objective-git-for-the-libgit2-test-fix
branch
from
September 21, 2026 13:22
64558d4 to
e982340
Compare
goneng
marked this pull request as ready for review
September 21, 2026 13:22
Collaborator
Author
Done - thanks! |
hannesa2
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every GitX build runs libgit2's cmake build, which compiled a Clar test
suite that is never run, because the flag meant to switch it off stopped
matching libgit2's own option name at the 1.x rename.
passes
-DBUILD_TESTS:BOOL=OFFin place of the dead-DBUILD_CLAR:BOOL=OFFand cuts 471 of the 667 objects the buildcompiles.
has since moved on to unrelated work in Fix two defects left by the libgit2 1.x API migration objective-git#107.
What it saves
libgit2 is rebuilt from scratch several times in every CI job, because
the script always does
rm -rf buildand runs both as its own step andagain from the ObjectiveGit target's Run Script phase. The arm64 job
builds it three times, in
pre build,Run unit testsandBuild project; the x86_64 job twice, lacking the unit test step. So thesaving lands once per build, several times per job.
Measured against run 35601332529, the pull request run 14 minutes before
this one on the same workflow, with two runs of this branch shown because
the spread between them is worth seeing:
pre buildBuild projectpre buildRun unit testsBuild projectCall it 4 to 6 minutes off the x86_64 job and around 3 minutes off the
arm64 one. The two runs after the change built byte-identical trees, so
the spread between them is runner variance, and the x86_64 figure in
particular should be read as a range rather than a number. What is not
noisy is the object count, which is exactly 196 per build against 667
before, every time.
Job totals move further than the steps above, from 14m07s to 6m53s and
16m41s to 8m24s, but some of that is unrelated: this pull request skips
notarization, having no signing secrets from a fork, and skips
Run tests, since a submodule bump cannot change the screenshots.Test plan
logs show 196 objects compiled per libgit2 build with none of them
tests, against 667 with 470 tests before.
Stop building the libgit2 test suite on every build objective-git#108 landed. The two are byte-identical trees, and CI
is green on both.
External/libgit2.aof the same size to the byte, 6,433,360, exportingan identical set of 2,097 global text symbols.
macos-15-intelandmacos-26, throughxcodebuild archive.