Repository navigation
Stop CI running the unit tests twice on every pull request - #706
Merged
Merged
Conversation
The screenshot step tests the whole scheme, so it repeats the GitXTests run that has already passed in its own step earlier in the same job. - Point the "Run tests" step at `make ui-test`, narrowing it to GitXUITests. Every other argument stays as it was, including the result bundle the screenshot extraction reads afterwards. - Update the Makefile's map of targets to CI steps, since `all-tests` now matches no step and is left as a way to run everything locally in one command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The screenshot step tests the whole scheme, so it repeats the GitXTests
run that has already passed in its own step earlier in the same job.
make ui-test, narrowing it toGitXUITests. Every other argument stays as it was, including the
result bundle the screenshot extraction reads afterwards.
all-testsnow matches no step and is left as a way to run everything locally
in one command.
What the duplicate costs, and why it is worth removing anyway, is in
#705.
Test plan:
ui-testisall-testsplus-only-testing:GitXUITestsand nothing else, so the result bundle thescreenshot steps read is unchanged.
make ui-testinto a result bundle followed byscripts/extract_screenshots.pyproduced the three screenshots, whichis the pair of steps this touches.
unit tests, the baseline UI tests, and this one.
Closes #705