Repository navigation
Stop the screenshot tests spending a minute changing view - #700
Conversation
|
Correcting my own description above: the earlier version claimed this fixed the My load diagnosis was wrong. The real cause is |
|
Predicting this before the run reports, so it is not read as an excuse afterwards: this PR's CI may still be red, and a green would not be evidence either.
This only stops the leak at source once it is on master. #702 is the one that unblocks CI now, since it defends the wiring tests whatever set the preference. |
Reach the history and commit views through the Command-1 and Command-2 key equivalents they already carry, rather than walking the menu bar through the accessibility hierarchy for tens of seconds a test. - Drop the menu bar traversal, which dominated two of the tests: on one machine they fall from 62s and 63s to 20s and 16s. - Take the view on screen as proof of arrival rather than the click landing, and tell the history view apart by the absence of the commit view's button, both views carrying tables.
Return to the history view before the app is terminated, so that a run does not decide which view the next launch comes up in. - PBShowStageView remembers the commit view, and testStagingTabScreenshot runs last alphabetically and switched to it without ever switching back. - Do this in tearDown rather than at the end of that test, since a failure part-way through skips anything after it, and a failing run is exactly when the state must not leak.
8e8299b to
3d2eac4
Compare
|
Screenshot differs: emulatorApi=arm64 with 2 screenshot(s) |
Reach the history and commit views through the Command-1 and Command-2
key equivalents they already carry, rather than walking the menu bar
through the accessibility hierarchy for tens of seconds a test, and stop
the suite leaving the app on the commit view when it finishes.
landing, and tell the history view apart by the absence of the commit
view's button, both views carrying tables.
view is remembered in
PBShowStageView,testStagingTabScreenshotruns last alphabetically and switched to it without switching back, so
every run left the preference set for whatever launched next.
Test plan
make ui-testpasses all four tests, and the three screenshots stillcome out with three distinct hashes.
PBShowStageViewset beforehand, the suite leaves it clearafterwards.
20s and 16s; the suite as a whole from 148s to 69s.