Skip to content

Key the CI run-keeping on the label the pipeline PRs already carry - #687

Merged
hannesa2 merged 1 commit into
masterfrom
keep-runs-on-the-pipeline-label
Sep 19, 2026
Merged

hannesa2 merged 1 commit into
masterfrom
keep-runs-on-the-pipeline-label

Conversation

@goneng

@goneng goneng commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Follow-up to #684, which merged with the question still open in its body: whether to key this on a new keep-runs label or on pipeline, which the screenshot pull requests already carry. This takes the second option, so nobody has to remember a second label.

-  cancel-in-progress: ${{ !contains(github.event.pull_request.labels.*.name, 'keep-runs') }}
+  cancel-in-progress: ${{ !contains(github.event.pull_request.labels.*.name, 'pipeline') }}

What this changes in practice

keep-runs has since been created and applied to #661 and #666, so #684 is no longer inert. Moving to pipeline widens who is covered:

pull request labels keeps runs today keeps runs after this
#661, #666 pipeline, keep-runs yes yes
#658 WIP, pipeline no yes
#681 pipeline no yes
#519, #517, #414 wontfix, pipeline no yes
everything else none no no

That is the point if pipeline means "this pull request exists to exercise CI", since those are exactly the ones whose artifacts are worth keeping. It is the wrong call if pipeline is used more loosely, in which case #684 is already right as it stands and this should be closed.

Worth knowing eitherway: #414, #517 and #519 also carry wontfix, so they are long-lived branches that would now run every push to completion.

Test plan

  • YAML.load_file parses the workflow and reads the expression back, so the syntax is sound.
  • This pull request carries no labels, so it is the unlabelled case: a second push to it should cancel the first run, as today.
  • Labelling any pull request pipeline and pushing twice should leave both runs alive, each uploading its own artifacts.

#684 landed with the open question in its body unanswered: whether to
key this on a new `keep-runs` label or on `pipeline`, which the
screenshot pull requests already carry.

* Read `cancel-in-progress` from `pipeline` rather than `keep-runs`, so
  a pull request that is already marked as CI work keeps its runs
  without anyone having to remember a second label.
@goneng goneng added the WIP Work in progress label Sep 19, 2026
@hannesa2

Copy link
Copy Markdown
Contributor

Screenshot differs: emulatorApi=arm64 with 4 screenshot(s)

setpoint (old) | diff | actual screenshot (new)

00-commit-context-menu.pngscreenshot

01-history-view.pngscreenshot

02-main-window.pngscreenshot

03-staging-view.pngscreenshot

Comment thread .github/workflows/BuildPR.yml Resolved
@goneng
goneng marked this pull request as ready for review September 19, 2026 12:05
@goneng goneng added pipeline CI pipeline and removed WIP Work in progress labels Sep 19, 2026
@hannesa2
hannesa2 merged commit 65c685a into master Sep 19, 2026
4 of 5 checks passed
@hannesa2
hannesa2 deleted the keep-runs-on-the-pipeline-label branch September 19, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipeline CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants