Repository navigation
Key the CI run-keeping on the label the pipeline PRs already carry - #687
Merged
Merged
Conversation
#684 landed with the open question in its body unanswered: whether to key this on a new `keep-runs` label or on `pipeline`, which the screenshot pull requests already carry. * Read `cancel-in-progress` from `pipeline` rather than `keep-runs`, so a pull request that is already marked as CI work keeps its runs without anyone having to remember a second label.
Contributor
hannesa2
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Follow-up to #684, which merged with the question still open in its body: whether to key this on a new
keep-runslabel or onpipeline, which the screenshot pull requests already carry. This takes the second option, so nobody has to remember a second label.What this changes in practice
keep-runshas since been created and applied to #661 and #666, so #684 is no longer inert. Moving topipelinewidens who is covered:pipeline,keep-runsWIP,pipelinepipelinewontfix,pipelineThat is the point if
pipelinemeans "this pull request exists to exercise CI", since those are exactly the ones whose artifacts are worth keeping. It is the wrong call ifpipelineis used more loosely, in which case #684 is already right as it stands and this should be closed.Worth knowing eitherway: #414, #517 and #519 also carry
wontfix, so they are long-lived branches that would now run every push to completion.Test plan
YAML.load_fileparses the workflow and reads the expression back, so the syntax is sound.pipelineand pushing twice should leave both runs alive, each uploading its own artifacts.