Skip to content

Remove a flood of maybe irrelevant warnings - #685

Merged
hannesa2 merged 1 commit into
masterfrom
RemoveWarnings
Sep 19, 2026
Merged

Remove a flood of maybe irrelevant warnings#685
hannesa2 merged 1 commit into
masterfrom
RemoveWarnings

Conversation

@hannesa2

@hannesa2 hannesa2 commented Sep 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

refs: gitx/objective-git#106

I see a lot of these warnings, and as a non objective-c developer, I try to remove them.
@goneng does this make sense to you ?

/Users/hannes/Library/Developer/Xcode/DerivedData/GitX-awximyutapdzbiaifesrdhkbxnfz/Build/Products/Debug/ObjectiveGit.framework/Headers/GTRepository+Merging.h:9:9: warning: 
      double-quoted include "GTRepository.h" in framework header, expected angle-bracketed instead [-Wquoted-include-in-framework-header]
    9 | #import "GTRepository.h"
      |         ^~~~~~~~~~~~~~~~
      |         <ObjectiveGit/GTRepository.h>

/Users/hannes/Library/Developer/Xcode/DerivedData/GitX-awximyutapdzbiaifesrdhkbxnfz/Build/Products/Debug/ObjectiveGit.framework/Headers/GTRepository+Merging.h:10:9: warning:

      double-quoted include "GTIndexEntry.h" in framework header, expected angle-bracketed instead [-Wquoted-include-in-framework-header]
   10 | #import "GTIndexEntry.h"
      |         ^~~~~~~~~~~~~~~~
      |         <ObjectiveGit/GTIndexEntry.h>

In file included from /Users/hannes/git/gitx/Resources/GitX_Prefix.pch:5:

In file included from /Users/hannes/Library/Developer/Xcode/DerivedData/GitX-awximyutapdzbiaifesrdhkbxnfz/Build/Products/Debug/ObjectiveGit.framework/Headers/ObjectiveGit.h:44:
In file included from /Users/hannes/Library/Developer/Xcode/DerivedData/GitX-awximyutapdzbiaifesrdhkbxnfz/Build/Products/Debug/ObjectiveGit.framework/Headers/GTRepository+Merging.h:10:
/Users/hannes/Library/Developer/Xcode/DerivedData/GitX-awximyutapdzbiaifesrdhkbxnfz/Build/Products/Debug/ObjectiveGit.framework/Headers/GTIndexEntry.h:32:9: warning: 
      double-quoted include "GTObject.h" in framework header, expected angle-bracketed instead [-Wquoted-include-in-framework-header]
   32 | #import "GTObject.h"
      |         ^~~~~~~~~~~~
      |         <ObjectiveGit/GTObject.h>

In file included from /Users/hannes/git/gitx/Resources/GitX_Prefix.pch:5:

In file included from /Users/hannes/Library/Developer/Xcode/DerivedData/GitX-awximyutapdzbiaifesrdhkbxnfz/Build/Products/Debug/ObjectiveGit.framework/Headers/ObjectiveGit.h:46:
/Users/hannes/Library/Developer/Xcode/DerivedData/GitX-awximyutapdzbiaifesrdhkbxnfz/Build/Products/Debug/ObjectiveGit.framework/Headers/GTCommit.h:31:9: warning: 
      double-quoted include "GTObject.h" in framework header, expected angle-bracketed instead [-Wquoted-include-in-framework-header]
   31 | #import "GTObject.h"
      |         ^~~~~~~~~~~~
      |         <ObjectiveGit/GTObject.h>

There are a lot if remaining warnings (git2.h, git2/annotated_commit.h, etc.) which come from vendored upstream libgit2 itself, which uses quoted includes as normal C-library convention. Rewriting all of libgit2's own headers is out of scope (huge, third-party, would need to be done/maintained upstream).
So I use CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER to get rid of them

@hannesa2
hannesa2 requested a review from goneng September 19, 2026 09:55
@goneng

goneng commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

@hannesa2 , want me to further investigate this one?

@hannesa2

hannesa2 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

If you see space for improvement here, go ahead ! Otherwise I'll merge it, if nothing against it.
Improvement can be applied every time

@goneng

goneng commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

The two lines in GitX.xcodeproj already do the whole job: measured 359 of these warnings -> 0 against our current pin, so the submodule bump is not what makes our build quiet.

The bump pins 24dcba45, which exists only on the RemoveWarnings branch of gitx/objective-git and is already superseded there by c732eab6. If that PR is squashed and the branch deleted, clone --recursive breaks for everyone.

Suggestion: merge the two GitX lines now, and pin the submodule after gitx/objective-git#106 lands on master.

@hannesa2
hannesa2 force-pushed the RemoveWarnings branch 3 times, most recently from 3400820 to b7abd22 Compare September 19, 2026 14:12
@hannesa2 hannesa2 changed the title Remove a flood of maybe irrelavant warnings Remove a flood of maybe irrelevant warnings Sep 19, 2026
@hannesa2
hannesa2 merged commit 1cf976d into master Sep 19, 2026
3 checks passed
@hannesa2
hannesa2 deleted the RemoveWarnings branch September 19, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goneng goneng Awaiting requested review from goneng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannesa2 @goneng