Skip to content

Skip unneeded screenshot tests - #681

Closed
hannesa2 wants to merge 1 commit into
masterfrom
SkipUnneededScreesnshotTest
Closed

hannesa2 wants to merge 1 commit into
masterfrom
SkipUnneededScreesnshotTest

Conversation

@hannesa2

Copy link
Copy Markdown
Contributor

About half of recent merges touch neither Classes/ nor Resources/ - CI-config, Makefile, test wiring, submodule bumps - and for those the comparison can only ever report "no change". Skip the baseline build for them rather than spending a second full build to prove a negative.

I grab from #658 this use full functionality, till it is merged

@hannesa2 hannesa2 added the pipeline CI pipeline label Sep 19, 2026
@hannesa2 hannesa2 mentioned this pull request Sep 19, 2026
@hannesa2
hannesa2 marked this pull request as draft September 19, 2026 07:23
@hannesa2
hannesa2 force-pushed the SkipUnneededScreesnshotTest branch from 4b104f6 to 6e1c718 Compare September 19, 2026 07:31
goneng added a commit to goneng/gitx that referenced this pull request Sep 19, 2026
Cancelling a superseded run throws away the artifacts it would have
uploaded, which is the very thing the screenshot experiments in gitx#658,
gitx#661 and gitx#681 exist to look at, and it makes each variant wait for the
running build before it can start. Raised by hannesa2 on gitx#623.

- Read cancel-in-progress from the pull request's labels, so that a
  pull request labelled keep-runs runs every push to completion
- Leave every other pull request cancelling as it does now, and master
  and tag builds untouched, since their group is keyed per run
@hannesa2

Copy link
Copy Markdown
Contributor Author

obsolete because #658 is merged

@hannesa2 hannesa2 closed this Sep 19, 2026
@hannesa2
hannesa2 deleted the SkipUnneededScreesnshotTest branch September 19, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipeline CI pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant