Skip to content

Cosmetic: Move the content of the preference panes a bit to the left (where their title starts) - #674

Merged
hannesa2 merged 1 commit into
masterfrom
start-panes-at-the-title
Sep 19, 2026
Merged

hannesa2 merged 1 commit into
masterfrom
start-panes-at-the-title

Conversation

@goneng

@goneng goneng commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #673, which put the three panes on shared columns but left
that column 12pt to the right of the pane title, so the window still
read as if its contents were pushed off to one side.

  • Move the content of all three panes left onto the title's column,
    keeping the columns they now share
  • Leave the Check Now button centered, since it acts for the whole
    Updates pane rather than belonging to that column

Screenshots

'General' pane

Before:

image

After:

image

Test plan

  • The pane title's first glyph starts at x=92 in window coordinates;
    the accessibility tree now reports the options column at 92, the
    sub-options at 113 and the controls at 207, where they were 104,
    125 and 219
  • ibtool --errors --warnings --notices reports no errors and no new
    notices against master
  • Open Preferences and switch between the tabs to check that nothing
    shifts sideways between them

The content of every pane sat 12pt to the right of the pane title, so
the window read as if its contents were pushed off to one side.

- Move the content of all three panes left onto the title's column,
  keeping the columns they now share
- Leave the Check Now button centered, since it acts for the whole
  Updates pane rather than belonging to that column
@hannesa2

Copy link
Copy Markdown
Contributor

Screenshot differs: emulatorApi=arm64 with 4 screenshot(s)

setpoint (old) | diff | actual screenshot (new)

00-commit-context-menu.pngscreenshot

01-history-view.pngscreenshot

02-main-window.pngscreenshot

03-staging-view.pngscreenshot

@goneng goneng changed the title Fix the preference panes not starting where their title starts Cosmetic: Move the content of the preference panes a bit to the left (where their title starts) Sep 18, 2026
@goneng
goneng marked this pull request as ready for review September 18, 2026 23:27

@hannesa2 hannesa2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the screenshots !
Unfortunately the screenshot compare mechanism is WIP, otherwise we would see it automatically

@hannesa2
hannesa2 merged commit 423af8d into master Sep 19, 2026
3 checks passed
@hannesa2
hannesa2 deleted the start-panes-at-the-title branch September 19, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants