Skip to content

Fix the preference panes each using their own layout and sizes - #673

Merged
hannesa2 merged 1 commit into
masterfrom
align-integration-preferences
Sep 18, 2026
Merged

hannesa2 merged 1 commit into
masterfrom
align-integration-preferences

Conversation

@goneng

@goneng goneng commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

The panes drifted apart over time: Integration and Updates sat on
different left columns from General, several controls used the small
system font while their neighbours used the regular one, and the
margins were tight enough that every pane looked crowded.

  • Put all three panes on the same columns, with sub-options indented
    one step under the option they belong to
  • Move the seven controls that still used the small system font onto
    the regular one, at the regular control size
  • Separate the terminal setting, the Gist options and Enable Gravatar
    from each other with vertical space, and widen the top and bottom
    margins of every pane by the height of a line of text
  • Center the Check Now button, which acts for the whole Updates pane

The explanatory text under Git Executable keeps the small size, which
is what that size is for.

The last-update date is the one change here that is not layout: at the
regular font size the full style measures 296pt in en_US against the
265pt its row has, so it would clip. The long style measures 219pt
and fits, at the cost of the weekday.

Screenshots

'General' pane

Before:

image

After:

image

'Integration' pane

Before:

image

After:

image

'Updates' pane

Before:

image

After:

image

Test plan

  • ibtool --errors --warnings --notices reports no errors and no new
    clipping, only the same intrinsic-height notice that every other
    label in this xib already carries
  • Built and run: the accessibility tree reports the shared columns on
    all three panes (options at 104, sub-options at 125, controls at
    219), regular-size controls, and Check Now centered at 249.5 in a
    500pt pane
  • Open Preferences and switch between the tabs to check that labels
    and controls do not shift sideways

The panes drifted apart over time: Integration and Updates sat on
different left columns from General, several controls used the small
system font while their neighbours used the regular one, and the
margins were tight enough that every pane looked crowded.

- Put all three panes on the same columns, with sub-options indented
  one step under the option they belong to
- Give every control the regular system font and control size, and
  shorten the last-update date so that it still fits its row
- Separate unrelated groups with vertical space, and widen the top and
  bottom margins by the height of a line of text
- Center the Check Now button, which acts for the whole Updates pane
@hannesa2

Copy link
Copy Markdown
Contributor

Screenshot differs: emulatorApi=arm64 with 4 screenshot(s)

setpoint (old) | diff | actual screenshot (new)

00-commit-context-menu.pngscreenshot

01-history-view.pngscreenshot

02-main-window.pngscreenshot

03-staging-view.pngscreenshot

@goneng
goneng marked this pull request as ready for review September 18, 2026 19:11
@hannesa2
hannesa2 merged commit 8a443af into master Sep 18, 2026
6 checks passed
@hannesa2
hannesa2 deleted the align-integration-preferences branch September 18, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants