Repository navigation
Fix the preference panes each using their own layout and sizes - #673
Merged
Merged
Conversation
The panes drifted apart over time: Integration and Updates sat on different left columns from General, several controls used the small system font while their neighbours used the regular one, and the margins were tight enough that every pane looked crowded. - Put all three panes on the same columns, with sub-options indented one step under the option they belong to - Give every control the regular system font and control size, and shorten the last-update date so that it still fits its row - Separate unrelated groups with vertical space, and widen the top and bottom margins by the height of a line of text - Center the Check Now button, which acts for the whole Updates pane
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




The panes drifted apart over time: Integration and Updates sat on
different left columns from General, several controls used the small
system font while their neighbours used the regular one, and the
margins were tight enough that every pane looked crowded.
one step under the option they belong to
the regular one, at the regular control size
from each other with vertical space, and widen the top and bottom
margins of every pane by the height of a line of text
The explanatory text under Git Executable keeps the small size, which
is what that size is for.
The last-update date is the one change here that is not layout: at the
regular font size the
fullstyle measures 296pt in en_US against the265pt its row has, so it would clip. The
longstyle measures 219ptand fits, at the cost of the weekday.
Screenshots
'General' pane
Before:
After:
'Integration' pane
Before:
After:
'Updates' pane
Before:
After:
Test plan
ibtool --errors --warnings --noticesreports no errors and no newclipping, only the same intrinsic-height notice that every other
label in this xib already carries
all three panes (options at 104, sub-options at 125, controls at
219), regular-size controls, and Check Now centered at 249.5 in a
500pt pane
and controls do not shift sideways