Repository navigation
Conversation
…#637) GitX has been able to drive iTerm2 for years, but the choice was reachable only through defaults write, so nobody could find it. * Offer the handlers GitX can actually drive in the Integration pane, greying out one that is not installed and saying so in its tooltip. A third terminal cannot be added by listing it: each needs its own Scripting Bridge header and its own API. * Move the handler list, display names and installed check into PBTerminalUtil, beside the code that drives them, and settle an unrecognized preference there, so the run path no longer logs and guesses at the point of use. * Add PBTerminalHandlerPreferenceTests over that choice, which is where a preference written by hand can hold anything at all.
goneng
marked this pull request as ready for review
September 17, 2026 21:45
Contributor
|
As you pull request comes from your fork, I can't test it easily as no artifact is provided here |
Collaborator
Author
Right - sorry - moved to #667, which is branched on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #637.
GitX has been able to drive iTerm2 for years, but the choice was reachable only
through
defaults write, so in practice nobody could find it.Changes
out one that is not installed and saying so in its tooltip. A third terminal
cannot be added by listing it: each needs its own Scripting Bridge header and
its own API.
PBTerminalUtil, beside the code that drives them, and settle anunrecognized preference there, so the run path no longer logs and guesses at
the point of use.
PBTerminalHandlerPreferenceTestsover that choice, which is where apreference written by hand can hold anything at all.
Test plan
settles to the default rather than reaching the run path unrecognized