Repository navigation
Remove deprecated API shims - #657
Conversation
|
Screenshot differs: emulatorApi=arm64 with 4 screenshot(s) |
There was a problem hiding this comment.
🟡 Changes recommended
One or more issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR updates the ObjectiveGit submodule to migrate libgit2 calls away from deprecated API names.
Changes:
- Updates the ObjectiveGit submodule revision.
- Migrates buffer, credential, reference, remote, index, and OID APIs.
- Deprecated usages remain in ObjectiveGit, tests, and GitX call sites.
File summaries
| File | Description |
|---|
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved deprecated API and buffer-ownership concerns remain.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
goneng
left a comment
goneng
left a comment
There was a problem hiding this comment.
Looks good: built it here and the suite is green (129 tests), and every substitution checks out as equivalent against the 1.9.4 headers, including the git_buf_grow(buf, 0) removal, which was already a no-op. It clears 13 of the 15 shim imports, so I will track the last two (GTFilter.m, NSData+Git.m) separately rather than hold this up.
|
The bump itself looks good. Exactly one commit ahead ( Could you change Also, correcting something I said over on #102: Order only matters in one direction: |
2321bff to
2c1de7f
Compare
|
Screenshot differs: emulatorApi=arm64 with 4 screenshot(s) |
refs #652