Repository navigation
Version without -HEAD on a tag - #651
Merged
Merged
Conversation
hannesa2
changed the title
hannesa2
force-pushed
the
VersionWithout-head
branch
from
September 15, 2026 16:58
ac134d4 to
0735ca9
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Guard the no-reachable-tags git describe call and explicitly apply the fallback.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR extracts Git-based version generation into a reusable script and removes the redundant -HEAD suffix.
Changes:
- Adds detached-HEAD version handling.
- Updates the Xcode build phase to invoke the script.
File summaries
| File | Summary |
|---|---|
scripts/set-git-version-info.sh |
Implements version generation and plist updates; tagless checkouts may abort before the documented fallback. |
GitX.xcodeproj/project.pbxproj |
Invokes the extracted versioning script. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Update version info script to handle missing tags. Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Contributor
Author
|
Screenshot differs: emulatorApi=arm64 with 4 screenshot(s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On recent brew version, I see this
The
-HEADis pointless here.During development I pointed out, that this line was >2200 characters, this was no more readable, so I extracted it to a script