Repository navigation
Fix the released zip opening as a damaged app - #649
Merged
Merged
Conversation
This was referenced Sep 14, 2026
`zip -r` follows symlinks unless it is given `-y`, so the zip assets on the releases page carry no symlinks at all. Every embedded framework has its `Versions/Current` stored as a second copy of the directory rather than a link to `Versions/A`, which leaves the bundle unverifiable, and macOS tells whoever downloads it that the app is damaged and should be moved to the Trash. The dmg is built a few lines earlier with `hdiutil create -srcfolder`, which preserves the links, so only the zip is affected. Homebrew installs the dmg, which is why this has gone unnoticed. * Store the symlinks rather than following them, so the frameworks keep the layout the signature was made over * Leave the packing quiet unless VERBOSE is set, since naming every file adds close to six hundred lines to a release log
goneng
force-pushed
the
fix-release-zip-symlinks
branch
from
September 14, 2026 22:21
cc95307 to
2bfb037
Compare
goneng
marked this pull request as ready for review
September 14, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zip -rfollows symlinks unless it is given-y, so the zip assets on thereleases page carry no symlinks at all. Every embedded framework has its
Versions/Currentstored as a second copy of the directory instead of a link toVersions/A, which leaves the bundle unverifiable, and macOS tells whoeverdownloads it that the app is damaged and should be moved to the Trash.
The dmg is built a few lines earlier with
hdiutil create -srcfolder, whichpreserves the links, so only the zip is affected. Homebrew installs the dmg,
which is why this has gone unnoticed.
Changes
zip -r -y, which stores the symlinks rather than following themVERBOSEis set, since naming every file adds594 lines to a release log
Test plan
Packing a known-good signed
GitX.appthree ways and verifying the extractedcopy with
codesign --verify --deep --strict:unzipditto -x -kzip -r(before)zip -r -y(this)ditto -c -k._*filesdittowas the first attempt here. It only verifies when it is also theextractor: unzipped, it scatters AppleDouble files and
codesignreportsa sealed resource is missing or invalid.zip -yholds up under both.make -n package-signedexpands as expected with the default variables andwith the ones the workflow passes (
EXPORT_DIR=.,ZIP=GitX-arm64.zip), anddrops
-qunderVERBOSE=1GitX-arm64.zipfor 1.5.7 reproduces the user-visible symptom:extract, launch, and macOS offers to move the app to the Trash. The 1.5.7 dmg
launches normally.
Gatekeeper was not re-tested end to end: the bundle used here is Development
signed rather than notarized, so
spctlrejects it whatever packs it. Thecodesignresults above are the meaningful ones.