Repository navigation
Stop the wiring tests racing the revision list - #644
Merged
Merged
Conversation
The revision list walks the repository on a background queue that outlives the test body, so every one of these tests deleted its fixture while a walk was still reading it. The walk then failed, and the assertion it raises landed on whichever test happened to be running. * Let each test start from a settled revision list, rather than competing with a walk that is still filling the history * Cancel the walk and wait for it to stop before the fixture is removed
Contributor
|
Screenshot differs: emulatorApi=arm64 with 4 screenshot(s) |
hannesa2
approved these changes
Sep 15, 2026
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #643.
The revision list walks the repository on a background queue that outlives the
test body. Every one of these tests deleted its fixture while a walk was still
reading it, so the walk failed and the assertion in
-addCommitsFromEnumerator:landed on whichever test happened to be running.
The overlap was always present, not occasional. Logging
isUpdatingattearDown:isUpdatingwhen the fixture is deletedThat is why the failures looked random and moved between tests, and why they
only showed up when the machine was busy.
Test plan
isUpdatingattearDownon both branches, as above