Repository navigation
Fix the stage view leaving a gap above its bar in dark mode - #642
Merged
Merged
Conversation
Dark mode in these views is not a theme but a whole page inversion filter, so it is the one appearance where the layout differs. On macOS 26 a filtered element also became the containing block for the fixed bar above the diff, which dropped the bar below the margin reserved for it and left an empty strip at the top. * Let the bar sit in the flow as a sticky element, so it no longer depends on being positioned against the viewport * Drop the margin reserving a guessed 30px for a bar that measures 23.5px, and the full width that would overflow once it is in the flow
goneng
marked this pull request as ready for review
September 14, 2026 19:42
Contributor
As soon as the build completes, I'll test on macOS 27 |
Contributor
|
Screenshot differs: emulatorApi=arm64 with 4 screenshot(s) |
Contributor
|
Hello, I confirm this fixed on 27.0 (I'm pretty confident that it would be the same on 26.x) Dark
Ligh
|
Collaborator
Author
Great, and yes - the change in behavior was introduced in macOS 26 (which is way it worked OK before that). @hannesa2, I think we can merge this one - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #481.
Dark mode in these views is not a theme. It is a whole page inversion
filter applied to
body, so dark is the one appearance where the layoutdiffers from light:
On macOS 26 a filtered element also became the containing block for
position: fixeddescendants.The stage view's bar is the only
position: fixedin the app, so in dark mode it stopped being positionedagainst the viewport and dropped below the 30px margin that
bodyreserves for it,leaving the empty strip the reporter sees.
Light mode has no filter, so it was never affected.
The bar is now a sticky element in the flow, which does not depend on the viewport and
does not need a margin reserved for it.
diff.cssalready usesposition: stickyin this same document, so the approach is not new here.Measured
#titlein the same document, toggling only the dark class:BODYBODYnullBODYPlease verify on macOS 26
The reproduction is macOS 26 only. On macOS 15 the old CSS already behaves
correctly, so this was developed against the mechanism rather than against
a local repro, and the patch is confirmed to cause no regression there.
@tagliala, would you try the build from this PR?
Test plan
top with no gap above it and the first line of the diff is readable