Repository navigation
Fix the signing goals failing where no Dev.xcconfig exists - #634
Merged
Merged
Conversation
goneng
force-pushed
the
make-devxcconfig-a-prerequisite
branch
from
September 13, 2026 17:17
1f67bbc to
298c10e
Compare
A gitignored file cannot arrive with a clone or a worktree. `git worktree add` and a fresh clone both start without Dev.xcconfig, so smoke-test and dmg-signed archive ad-hoc and then fail in dyld with a Team ID error that reads like a broken branch. The Makefile already knows how to write the file; nothing ever asked it to. * Have the archive want Dev.xcconfig when smoke-test or dmg-signed asked for it, which is early enough that the archive is signed with it * Leave the other goals alone: CI archives with a Developer ID certificate the script does not look for, and `dmg` signs ad-hoc on purpose
goneng
force-pushed
the
make-devxcconfig-a-prerequisite
branch
from
September 13, 2026 19:51
298c10e to
477f66c
Compare
goneng
marked this pull request as ready for review
September 13, 2026 19:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A gitignored file cannot arrive with a clone or a worktree.
git worktree addand a fresh clone both start withoutDev.xcconfig, somake smoke-testandmake dmg-signedarchive ad-hoc and then fail in dyldwith a Team ID error that reads like a broken branch rather than a missing
local file. The Makefile already knows how to write that file; nothing ever
asked it to.
Dev.xcconfigwhensmoke-testordmg-signedaskedfor it, which is early enough that the archive itself is signed with it
make-dev-xcconfig.shdoes not look for, anddmgsigns ad-hoc on purposeThe prerequisite hangs off
archiverather than offsmoke-test, sincesmoke-test: app: archive- asking at the top would let the archive be builtad-hoc first, and the hardened-runtime guard would then fail exactly as it does
today.
Test plan
Dev.xcconfig,make -nasks for it fromsmoke-testanddmg-signed, and not fromarchive,dmg,app,buildor
unit-testscripts/make-dev-xcconfig.shis the first line printed, sothe config is written before
xcodebuildarchivesmake Dev.xcconfigin that worktree wrote a valid config from the keychaincertificate, and
git statusstays clean, since the file is ignoredmake mapstill parses the MakefileWith no certificate at all the script exits with its own explanation of how to
get one, which is a better answer than the dyld error.
One wrinkle worth knowing:
make mapwill not show the new edge, since theprerequisite only exists while one of those two goals is being asked for.