Repository navigation
Copy the right-clicked commit, not the selection (issue #406) - #621
Merged
Merged
Conversation
Right-clicking a commit that isn't selected opens the menu for that commit, and Checkout, Cherry Pick, Reset and the rest act on it, but Copy SHA, Copy short SHA and Copy Patch still copied whatever was selected. Pasting that SHA into a terminal then acts on the wrong commit. The copy actions now read the commit(s) the menu item was built for, and fall back to the selection for the Edit menu and key equivalents, which carry none.
hannesa2
approved these changes
Sep 13, 2026
hannesa2
left a comment
hannesa2
left a comment
Contributor
There was a problem hiding this comment.
Works as expected 👍
Thank you !
Collaborator
|
(LGTM - and found another cosmetic bug while reviewing this... 🙂) |
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #406.
Right-clicking a commit that isn't selected opens the menu for that commit.
Checkout, Cherry Pick, Reset and the other actions in that menu act on the
clicked commit:
menuItemsForCommits:stores it as each item'srepresentedObject, andrefishForSender:reads it back. The three copyitems (Copy SHA, Copy short SHA, Copy Patch) were the exception.
They read
commitController.selectedObjectsinstead, so they copied theselection, and a SHA pasted into a terminal pointed at the wrong commit.
The copy actions now go through a small
commitsForSender:helper that takesthe commit, or commits, from the menu item. It falls back to the selection
when the item carries none, which is the case for the Edit menu and ⌘C.
Right-clicking inside a multi-commit selection still copies the whole
selection, because the context menu is built for those commits.
Test plan
make unit-test: 75 tests, 0 failures, 4 of them new (inPBGitHistorySelectionTests)testAContextMenuItemCopiesTheClickedCommitNotTheSelectionandtestAContextMenuItemForSeveralCommitsCopiesThemAllfailSeparately: the repo's
.clang-formatlistsAllowShortFunctionsOnASingleLinetwice, and current clang-format (23.x) refuses to load it. I checked the
changed lines against a copy with the duplicate removed; they need no changes.