Repository navigation
Fix the first lines of a file hiding behind its tab bar - #605
Merged
Merged
Conversation
goneng
marked this pull request as ready for review
September 11, 2026 23:37
goneng
force-pushed
the
fix-file-view-under-the-type-bar
branch
2 times, most recently
from
September 12, 2026 09:36
1a3e2e1 to
52ec66d
Compare
Contributor
|
Just as hint: Somethimes a before/after-picture tells more about the desired change. |
Resizing a window left the file viewer stretched over the whole pane it shares with the Source, Blame and History bar, and the bar, drawn after it, covered the top of the file from then on. * Ask the controller which frame its web view is to occupy when a live resize ends, rather than handing it the whole pane * Answer that in the file view by stopping the viewer where the bar starts, so a bar laid out taller than the nib reserved for it takes the room from the viewer rather than from the file
goneng
force-pushed
the
fix-file-view-under-the-type-bar
branch
from
September 12, 2026 15:27
52ec66d to
fb425f5
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #598.
The Source, Blame and History bar shares its pane with the file viewer:
the bar sits in the top 25 points, the viewer fills the rest. Ending a
live window resize threw that away:
The viewer then covered the bar's 25 points too, and since the bar is the
later sibling it is drawn on top, hiding the first line and a half of
every file from then on. That is why it looks like a per-repository
problem: it is per-window, and it starts the first time that window is
resized.
PBWebControllernow asks itself which frame its web view is to occupy,which for every other web view in GitX is still the whole superview, and
GLFileViewanswers with the room below the bar.Test plan
GLFileViewLayoutTests: 3 tests, all failing on master, coveringthe viewer's frame at two pane heights and with a bar laid out taller
than the nib reserved for it
make unit-test: 52 tests, 0 failuressits at y=546, below the bar at 521..546. Dragging the window edge on
master moves it to y=521, under the bar; with this change it stays at
546 across repeated resizes
fills its own pane after a resize