Repository navigation
Convert the 'map' target in the Makefile to a native in-line, dropping the external script - #600
Merged
Merged
Conversation
Read the graph inline, so that the target travels with the Makefile it describes and can be lifted into another project by copying two rules. The script had drifted from the copy kept as a sample elsewhere, which had meanwhile learned to name the makefile it reads rather than assume it. Both now hold the same rules, and correctness no longer rests on the file happening to be called Makefile. - Move the pipeline and the awk into the recipe, dropping scripts/make-target-map.sh - Add MAKEFILE, so `-f` and the self-filter both name the file make read - Read the help text out of MAKEFILE_LIST, covering included fragments - Separate a description from its target with a tab
goneng
changed the title
goneng
marked this pull request as ready for review
September 11, 2026 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maplived in a helper script, which is not really required.Folding it into the Makefile and makes the target travel with the file it describes.
-fand the self-filter stop relyingon the file happening to be called Makefile
and give the sections headers
make mapnow reports and fails ratherthan printing an empty map
## (alias), sohelpstops hiding themTest plan:
make mapoutput checked against gawk 5.2.1, mawk 1.3.4, busybox awk and themacOS awk: byte identical on all four
make map MAKEFILE=/dev/null, an empty file and a broken one each reportmap: no targets found in ...and exit non-zeromake help,make -n unit-testunchanged