Repository navigation
Fix copying a patch crashing when a commit has none - #587
Merged
Merged
Conversation
Leave out the commits that cannot produce a patch instead of inserting their missing patch into the array being joined. - Declare the patch as absent, which is what it is once the format-patch task fails - Skip the commits the transformer has nothing to say about Copy Patch asks each selected commit for its patch and collects the results. The property was declared as always present, so the failure the getter already handled and logged reached the array as nil and raised, taking down the application rather than copying the commits that did produce a patch.
goneng
force-pushed
the
fix-copy-patch-crash
branch
from
August 23, 2026 13:53
167a08c to
25e5fc6
Compare
goneng
marked this pull request as ready for review
August 23, 2026 14:16
goneng
marked this pull request as draft
August 23, 2026 14:16
goneng
marked this pull request as ready for review
August 23, 2026 14:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leave out the commits that cannot produce a patch instead of inserting
their missing patch into the array being joined.
format-patch task fails
Copy Patch asks each selected commit for its patch and collects the
results. The property was declared as always present, so the failure
the getter already handled and logged reached the array as nil and
raised, taking down the application rather than copying the commits
that did produce a patch.
Test plan:
GitXCommitCopierTestsreproduces the crash with a commit whosepatch is absent; it raises
NSInvalidArgumentExceptionbefore thefix and passes after
xcodebuild test -only-testing:GitXTestsis green, 42/42