Repository navigation
Clear the NSWorkspace and open panel deprecation warnings - #585
Merged
hannesa2 merged 1 commit intoAug 23, 2026
Merged
Conversation
Replace the file-opening and open-panel calls that macOS deprecated in 11.0 and 12.0 with their documented successors. - Open the selected file through openURL: - Open the repository URLs one at a time, as the batch call has no successor that keeps each URL on its own default application - Filter the open panel by content type instead of file extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the file-opening and open-panel calls that macOS deprecated in
11.0 and 12.0 with their documented successors.
openURL:successor that keeps each URL on its own default application
Warnings go from 64 to 61 in GitX's own sources.
The remainder come from the vendored ObjectiveGit and libgit2 headers and
are not addressable from this repository.
The second point is the only real behavior change here, so it was
checked by hand rather than argued from the documentation.
Opening a multiple-file selection whose files belong to three different
applications opens all three, and does so indistinguishably from the
batch call it replaces.
Test plan
xcodebuild test -only-testing:GitXTestspasses 39/39 - unchangedtype filter, and confirmed the type built for the
gitextension is nevernil,since a
nilentry would throw as the panel opensapplications, and compared the result against a build of master