Skip to content

Clear the NSWorkspace and open panel deprecation warnings - #585

Merged
hannesa2 merged 1 commit into
gitx:masterfrom
goneng:clear-workspace-deprecation-warnings
Aug 23, 2026
Merged

hannesa2 merged 1 commit into
gitx:masterfrom
goneng:clear-workspace-deprecation-warnings

Conversation

@goneng

@goneng goneng commented Aug 23, 2026 •

Copy link
Copy Markdown
Collaborator

Replace the file-opening and open-panel calls that macOS deprecated in
11.0 and 12.0 with their documented successors.

  • Open the selected file through openURL:
  • Open the repository URLs one at a time, as the batch call has no
    successor that keeps each URL on its own default application
  • Filter the open panel by content type instead of file extension

Warnings go from 64 to 61 in GitX's own sources.
The remainder come from the vendored ObjectiveGit and libgit2 headers and
are not addressable from this repository.

The second point is the only real behavior change here, so it was
checked by hand rather than argued from the documentation.
Opening a multiple-file selection whose files belong to three different
applications opens all three, and does so indistinguishably from the
batch call it replaces.

Test plan

  • xcodebuild test -only-testing:GitXTests passes 39/39 - unchanged
  • Clean build drops exactly the three intended warnings and adds none
  • Opened a repository through File > Open, which exercises the content
    type filter, and confirmed the type built for the git extension is never nil,
    since a nil entry would throw as the panel opens
  • Opened a three-file selection covering three different default
    applications, and compared the result against a build of master

Replace the file-opening and open-panel calls that macOS deprecated in
11.0 and 12.0 with their documented successors.

- Open the selected file through openURL:
- Open the repository URLs one at a time, as the batch call has no
  successor that keeps each URL on its own default application
- Filter the open panel by content type instead of file extension
@goneng
goneng marked this pull request as ready for review August 23, 2026 12:20
@hannesa2
hannesa2 merged commit 1d56227 into gitx:master Aug 23, 2026
3 checks passed
@goneng
goneng deleted the clear-workspace-deprecation-warnings branch August 23, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants