Repository navigation
Clear the deprecation warnings that change no behavior - #583
Merged
Merged
Conversation
Replace three deprecated spellings whose successors were confirmed to produce identical results, so the cleanup carries no visual or runtime risk. - Take the emphasized and unemphasized selection colors, which measure identical in light, dark, and high-contrast appearances - Drop the border type, which a custom-style NSBox renders identically with or without it - Bind the clicked commit and the selected commits at their declared types, as the compiler reports both casts as always succeeding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear five deprecation warnings whose replacements were confirmed to
produce identical results, so nothing here can change what the app does.
selectedContentBackgroundColorandunemphasizedSelectedContentBackgroundColorfor the search resulthighlight; both measure byte-identical to the colors they replace in
the Aqua, Dark Aqua, and high-contrast appearances
setBorderType:from the rewind panel's box, which isNSBoxCustomand renders pixel-identical with or without ittypes, which the compiler already reports as always succeeding
Warnings go from 69 to 64 in GitX's own sources. The rest of the build's
warnings come from the vendored ObjectiveGit and libgit2 headers and are
not addressable from this repository.
Test plan
xcodebuild test -only-testing:GitXTestspasses 39/39, unchangednone, confirmed by diffing the deduplicated warning sets
assumed, since both would otherwise be silent visual changes