Repository navigation
Simplify building GitX outside of Xcode - #581
Merged
Merged
Conversation
goneng
changed the title
… Makefile Give the project one place to run what CI runs, so that a build, a test run or a local disk image is a single command rather than a remembered xcodebuild invocation. - Name the targets after the BuildPR.yml steps they mirror, so that a change on one side is visible from the other - Keep `dmg` unsigned for local use and put signing behind `dmg-signed`, which wants an ExportOptions.plist of your own - Point the README at `make help` alongside the build script shared in the discussion thread
Take the guesswork out of preparing a signable local build, so that a contributor holding a certificate gets the settings that match it, and one without is told exactly what is missing. - Read the team and the identity off the certificate itself, as `security find-identity` reports nothing for a key that Xcode filed in the data protection keychain - Name the cause on failure: no certificate, an expired one, or several teams to choose between - Hang the target on the file, so a config edited by hand is never written over
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the project one place to run what CI runs, so that a build, a test
run or a local disk image is a single command rather than a remembered
xcodebuild invocation.
change on one side is visible from the other
dmgrunnable without a signing identity, and put the signed,hardened-runtime image behind
dmg-signedcause when there is none to read
git-clean-dry-runlists what agit clean -Xdfwould take, and nothing runs it for youTest plan:
make unit-testpasses, 35 tests on arm64make dmgbuilds an image whose app mounts and launches; with acertificate in place
make archiveproduces a hardened-runtime buildthat launches too
make Dev.xcconfigreproduces a hand-written config, and its failurepaths were exercised against generated certificates: none, expired,
and several teams