Repository navigation
Stand up GitXTests unit-test target with a race-condition regression test - #566
Merged
Merged
Conversation
goneng
force-pushed
the
standup-gitxtests-unit-tests
branch
5 times, most recently
from
August 12, 2026 18:59
bc06789 to
14f1afb
Compare
…test The scheme already referenced a GitXTests target (BlueprintIdentifier BBCCDDA000000A00) in both BuildAction and TestAction, but it never actually existed in project.pbxproj -- a dangling reference. Recreate it as a real unit-test bundle (TEST_HOST/BUNDLE_LOADER against GitX.app) and repoint the scheme at its real target UUID. Add PBGitRevListRaceConditionTests.m, driving PBGitRevList's private loadGeneration/updateCommits:operation:generation: directly to assert a stale generation's flush is dropped and a current generation's flushes still accumulate -- covering the fix without depending on FSEvents/operation-queue timing.
goneng
force-pushed
the
standup-gitxtests-unit-tests
branch
from
August 14, 2026 17:56
14f1afb to
d15f35a
Compare
1 task done
goneng
marked this pull request as ready for review
August 14, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scheme already referenced a GitXTests target (BlueprintIdentifier BBCCDDA000000A00) in both BuildAction and TestAction, but it never actually existed in project.pbxproj -- a dangling reference.
Changes
xcodebuild testcurrently crashes launching the host process for a reason unrelated to this PR -- XCTest's bootstrap posts an NSUserDefaults change notification from a background thread when the test bundle is injected into the host process, and PBWebHistoryController.preferencesChanged calls into WebKit without a main-thread guard. That's the separate bug fixed in Dispatch preferencesChanged WebKit calls to the main thread #565.Test plan
xcodebuild testruns GitXTests without crashing on launch(Not Blocked)
Was blocked on #565, which is merged by now.